Skip to content

TestRateLimiterGoroutines is flaky #25

@RJPercival

Description

@RJPercival

It looks like there was an attempt to de-flake this last year, but it's not been 100% successful: 2174cda

running go test
ok  	github.com/google/certificate-transparency-go	8.096s	coverage: 44.8% of statements
ok  	github.com/google/certificate-transparency-go/asn1	1.105s	coverage: 85.2% of statements
ok  	github.com/google/certificate-transparency-go/client	23.788s	coverage: 77.1% of statements
?   	github.com/google/certificate-transparency-go/client/ctclient	[no test files]
ok  	github.com/google/certificate-transparency-go/fixchain	2.399s	coverage: 83.3% of statements
?   	github.com/google/certificate-transparency-go/fixchain/main	[no test files]
--- FAIL: TestRateLimiterGoroutines (13.88s)
	limiter_test.go:34: #4: Too many operations per second. Expected ~1000, got 1238
FAIL
coverage: 100.0% of statements
FAIL	github.com/google/certificate-transparency-go/fixchain/ratelimiter	28.332s

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions