Skip to content

Adding CEL Regex Extensions #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 1, 2025
Merged

Adding CEL Regex Extensions #1187

merged 17 commits into from
Jul 1, 2025

Conversation

maskri17
Copy link
Collaborator

@maskri17 maskri17 commented Jun 6, 2025 •
edited
Loading

Commit Messages

Adding Regex Extensions to cel-go

Adding regex functions such as replace, capture, catureAll, and captureAllNamed in accordance with [Regex Design Doc](https://docs.google.com/document/d/1j5VYoAPsKSXcC8xtP-haskOcPFiUT9MwhD-dyUTFs2Y/edit?tab=t.0).

@maskri17 maskri17 marked this pull request as draft June 10, 2025 18:14
@jnthntatum
Copy link
Collaborator

/gcbrun

@maskri17 maskri17 marked this pull request as ready for review June 10, 2025 23:26
@jnthntatum
Copy link
Collaborator

/gcbrun

@jnthntatum
Copy link
Collaborator

/gcbrun

jnthntatum
jnthntatum reviewed Jun 13, 2025
View reviewed changes
jnthntatum
jnthntatum reviewed Jun 17, 2025
View reviewed changes
@maskri17
Copy link
Collaborator Author

/gcbrun

@jnthntatum
Copy link
Collaborator

/gcbrun

jnthntatum
jnthntatum reviewed Jun 24, 2025
View reviewed changes
jnthntatum
jnthntatum requested changes Jun 25, 2025
View reviewed changes
jnthntatum
jnthntatum requested changes Jun 26, 2025
View reviewed changes
Copy link
Collaborator

@jnthntatum jnthntatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to defer until the updates for the java version are stable and consistent, but you will also want to update the /ext/README.md with documentation about the extension

jnthntatum
jnthntatum requested changes Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@jnthntatum jnthntatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM last round of documentation / style suggestions

@maskri17 maskri17 requested a review from jnthntatum July 1, 2025 18:54
@jnthntatum jnthntatum merged commit a4b169a into google:master Jul 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnthntatum jnthntatum jnthntatum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maskri17 @jnthntatum