Skip to content

fix(checker): Correct Sprintf argument count #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

cuishuang
Copy link
Contributor

@cuishuang cuishuang commented Jun 5, 2025

Pull Requests Guidelines

See CONTRIBUTING.md for more details about when to create
a GitHub Pull Request and when other kinds of contributions or
consultation might be more desirable.

When creating a new pull request, please fork the repo and work within a
development branch.

Commit Messages

In the notAnOptionalFieldSelectionCall method, the call to fmt.Sprintf
had a format string with three placeholders (%s, %d, %s) but only two
arguments were provided. This would cause the last %s to be rendered
as "%!s(MISSING)" at runtime.

This commit removes the redundant trailing %s placeholder from the
format string to ensure the number of arguments matches the placeholders,
thus fixing the error.

Reviews

  • Perform a self-review.
  • Make sure the Travis CI build passes.
  • Assign a reviewer once both the above have been completed.

Merging

  • If a CEL maintaner approves the change, it may be merged by the author if
    they have write access. Otherwise, the change will be merged by a maintainer.
  • Multiple commits should be squashed before merging.
  • Please append the line closes #<issue-num>: description in the merge message,
    if applicable.

…ectionCall

Signed-off-by: cuishuang <imcusg@gmail.com>
@TristonianJones
Copy link
Collaborator

/gcbrun

@cuishuang
Copy link
Contributor Author

Thanks.

@TristonianJones TristonianJones merged commit 050981e into google:master Jun 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants