Add support for a relative offset within ast.SourceInfo #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce support for a base line and column to be computed
by querying offset 0 on the
common.Sourcevalue providedto
NewSourceInfo.Previously, the
common.Sourcewas used directly within theparser and implementations could override the behavior of
OffsetLocationandLocationOffsetto produce values whichtreated the parse input as relative source in some larger context;
however, with the shift away from proto (#789) and toward more
uniform and featureful internal data types, the
ast.SourceInfoobject attempted to unify the id to offset relationship and removed
this feature on accident.