Skip to content

Conversation

bentrengrove
Copy link
Collaborator

Fixes #1714

@@ -12,7 +12,7 @@ gradlePlugin = "8.1.0"
lintMinCompose = "30.0.0"

ktlint = "0.45.2"
kotlin = "1.9.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking - is bumping Kotlin and the compiler require from accompanist? Just wondering if the transitive Kotlin bump here is worth it (or if that bump would be transitive anyway from base Compose)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always just release with the latest compiler to make sure we stay up to date with fixes there. I haven't heard an issue yet with an incompatible change

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking - is bumping Kotlin and the compiler require from accompanist? Just wondering if the transitive Kotlin bump here is worth it (or if that bump would be transitive anyway from base Compose)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploading Screenshot_٢٠٢٤٠١٠٣_١٣٣٠١٢_Chrome.jpg …

@@ -68,7 +67,6 @@ class NavDrawerFoldAwareColumnSample : ComponentActivity() {
@Composable
fun NavDrawerExample(activity: Activity) {
val icons = listOf(
Icons.Default.List,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Was this removed? Or was this one of the AutoMirrored icons?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was automirrored but the label looks weird in the sample because of splitting at the first .. It seemed easier to just remove it rather than fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.33.1-alpha is not compatible with compose 1.6.0-alpha06 or later
3 participants