Skip to content

Make TryFromBytes a super-trait of FromZeros #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 29, 2024
Merged

Make TryFromBytes a super-trait of FromZeros #952

merged 1 commit into from
Feb 29, 2024

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Feb 26, 2024

Makes progress on #5

@joshlf
Copy link
Member Author

joshlf commented Feb 26, 2024

This can't merge until #948 in order to make sure that any errors are caught by CI.

@joshlf joshlf force-pushed the from-zeros-try-from-bytes branch from 1d716e8 to 2838af0 Compare February 27, 2024 16:35
@joshlf joshlf enabled auto-merge February 27, 2024 16:35
@jswrenn jswrenn mentioned this pull request Feb 27, 2024
Closed
@jswrenn jswrenn force-pushed the from-zeros-try-from-bytes branch 3 times, most recently from 1376f5a to 5abe510 Compare February 29, 2024 21:30
@joshlf @jswrenn
Make TryFromBytes a super-trait of FromZeros
6a51167 
Makes progress on #5

Closes #962

Co-authored-by: Jack Wrenn <jswrenn@amazon.com>
@jswrenn jswrenn force-pushed the from-zeros-try-from-bytes branch from 5abe510 to 6a51167 Compare February 29, 2024 21:32
@joshlf joshlf added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit 26de2d3 Feb 29, 2024
@joshlf joshlf deleted the from-zeros-try-from-bytes branch February 29, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jswrenn jswrenn jswrenn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshlf @jswrenn