Skip to content

Support derive(TryFromBytes) on packed structs #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2024
Merged

Support derive(TryFromBytes) on packed structs #794

merged 1 commit into from
Jan 19, 2024

Conversation

jswrenn
Copy link
Collaborator

@jswrenn jswrenn commented Jan 19, 2024

Now that #715 supports unaligned Ptrs, we get support for repr(packed) 'for free' — this commit merely removes the anti-packed check from the derive.

Makes progress towards #5.

@jswrenn
[derive] support derive(TryFromBytes) on packed structs
2e37819 
Now that #715 supports unaligned `Ptr`s, we get support for
`repr(packed)` 'for free' — this commit merely removes the
anti-`packed` check from the derive.

Makes progress towards #5.
joshlf
joshlf approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@joshlf joshlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jswrenn jswrenn added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit 3b7a937 Jan 19, 2024
@jswrenn jswrenn deleted the tryfrombytes-packed branch January 19, 2024 17:41
@jswrenn jswrenn mentioned this pull request Jan 20, 2024
Closed
@joshlf joshlf changed the title Support derive(TryFromBytes) on packed structs. Support derive(TryFromBytes) on packed structs Jan 22, 2024
@joshlf joshlf mentioned this pull request Jan 22, 2024
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshlf joshlf joshlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jswrenn @joshlf