Replace safety_comment! with const blocks #2483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
approved these changes
Apr 5, 2025
Replace:
safety_comment! {
/// SAFETY:
/// ...
foo!();
bar!();
}
With:
// SAFETY: ...
const _: () = unsafe {
foo!();
bar!();
};
Remove the `safety_comment!` macro.
gherrit-pr-id: Id5df96f57c34a4e7e8d261399f01fd23cded339e
fe86a1d to
0d6a574
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2483 +/- ##
==========================================
- Coverage 90.44% 90.42% -0.02%
==========================================
Files 19 19
Lines 7522 7523 +1
==========================================
Hits 6803 6803
- Misses 719 720 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace:
safety_comment! {
/// SAFETY:
/// ...
foo!();
bar!();
}
With:
// SAFETY: ...
const _: () = unsafe {
foo!();
bar!();
};
Remove the
safety_comment!macro.This PR is on branch remove-safety-comment-macro.