Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.38%. Comparing base (ed32df4) to head (2dea8f2).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main    #2452   +/-   ##
=======================================
  Coverage   90.38%   90.38%           
=======================================
  Files          18       18           
  Lines        7288     7288           
=======================================
  Hits         6587     6587           
  Misses        701      701           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I've put up #2456 to migrate impl_block to a builder pattern, which might make your life easier here (so that passing the crate name around isn't quite as painful).

Thanks for getting that builder in, certainly simplified things!

I found that the padding macros in src/util/macro_util.rs (struct_has_padding, union_has_padding, ...) had the crate hard coded so I fixed this too. The problem is that it's not picked up in the test I've included, and I could not think of a good way to test it given that the trick we're already using can't be applied in the same way. Potentially this is a non-issue given that using $crate is good practice anyway.

Thanks for getting that builder in, certainly simplified things!

np!

I found that the padding macros in src/util/macro_util.rs (struct_has_padding, union_has_padding, ...) had the crate hard coded so I fixed this too. The problem is that it's not picked up in the test I've included, and I could not think of a good way to test it given that the trick we're already using can't be applied in the same way. Potentially this is a non-issue given that using $crate is good practice anyway.

Yeah, agreed that $crate should be fine. Honestly not sure why we didn't just do that to begin with.

No problem, thank you for all your work!

This is now available in 0.8.24.