-
Notifications
You must be signed in to change notification settings - Fork 126
[CI] skip installation step when cache hit #1978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1978 +/- ##
=======================================
Coverage 89.46% 89.46%
=======================================
Files 16 16
Lines 5838 5838
=======================================
Hits 5223 5223
Misses 615 615 ☔ View full report in Codecov by Sentry. |
Thanks for this! Is this redundant with .github/actions/cache, which is also called from |
No, you are RIGHT!!! I should use that composite.
|
…y for wider cache range
Okay, that makes sense! And indeed, this seems to have considerably sped up CI: Compare to this run for #1981: |
* [ci] fix, showing cache hit, re-install dependencies * [ci] fix ci workflow to check the cache-hit output and add restore-key for wider cache range
fix #1730