-
Notifications
You must be signed in to change notification settings - Fork 124
Closed
Labels
compatibility-breakingChanges that are (likely to be) breakingChanges that are (likely to be) breakingcustomer-requestDocuments customer requests.Documents customer requests.documentationImprovements or additions to documentationImprovements or additions to documentationexperience-easyThis issue is easy, and shouldn't require much experienceThis issue is easy, and shouldn't require much experiencegood first issueGood for newcomersGood for newcomers
Description
slice_from_prefix
returnsOption<(&[Self], &[u8])>
slice_from_suffix
returnsOption<(&[u8], &[Self])>
mut_slice_from_prefix
returnsOption<(&mut [Self], &mut [u8])>
mut_slice_from_suffix
returnsOption<(&mut [u8], &mut [Self])>
However, all of the other methods drop the prefix/suffix:
FromBytes::read_from_prefix
returnsOption<Self>
FromBytes::read_from_suffix
returnsOption<Self>
FromBytes::ref_from_prefix
returnsOption<&Self>
FromBytes::ref_from_suffix
returnsOption<&Self>
FromBytes::mut_from_prefix
returnsOption<&mut Self>
FromBytes::mut_from_suffix
returnsOption<&mut Self>
This is desirable: the majority of the time I drop the prefix anyways and these are convenience methods for methods in Ref
.
[ref|mut]_from_[prefix|suffix]
in their docs both point to using Ref
to preserve the prefix/suffix.
Metadata
Metadata
Assignees
Labels
compatibility-breakingChanges that are (likely to be) breakingChanges that are (likely to be) breakingcustomer-requestDocuments customer requests.Documents customer requests.documentationImprovements or additions to documentationImprovements or additions to documentationexperience-easyThis issue is easy, and shouldn't require much experienceThis issue is easy, and shouldn't require much experiencegood first issueGood for newcomersGood for newcomers