-
Notifications
You must be signed in to change notification settings - Fork 124
Closed
Labels
blocking-next-releaseThis issue should be resolved before we release on crates.ioThis issue should be resolved before we release on crates.iocompatibility-breakingChanges that are (likely to be) breakingChanges that are (likely to be) breaking
Description
We have some types (such as Ref
and Unalign
) which implement Deref
, and which provide methods (such as into_ref
). This conflicts with the standard library's pattern of preferring associated functions over methods on types which implement Deref
(e.g., Box::into_raw
). This pattern is well-motivated: When a method is called on a Deref
type, it is resolved on both the type itself and the target type (e.g., on both Box<T>
and on T
), and so methods on the type itself (Box<T>
) can conflict with those on the target type (T
). We should consider adopting this pattern.
Metadata
Metadata
Assignees
Labels
blocking-next-releaseThis issue should be resolved before we release on crates.ioThis issue should be resolved before we release on crates.iocompatibility-breakingChanges that are (likely to be) breakingChanges that are (likely to be) breaking