Skip to content

Conversation

zhouwfang
Copy link
Contributor

#46

- remove Option
- apply new() directly instead of using another for loop
@zhouwfang zhouwfang requested a review from ia0 as a code owner January 7, 2025 05:02
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, but instead of removing the checks, I would move them to debug-mode only.

@zhouwfang zhouwfang changed the title Remove a for loop in side table creation Save a for loop in side table creation Jan 7, 2025
@zhouwfang zhouwfang changed the title Save a for loop in side table creation Remove Option in side table creation Jan 8, 2025
@zhouwfang zhouwfang requested a review from ia0 January 8, 2025 00:08
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ia0 ia0 merged commit 009a15d into google:dev/fast-interp Jan 8, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants