Skip to content

Conversation

ia0
Copy link
Member

@ia0 ia0 commented Mar 7, 2025

The main changes are:

  • Do not create a branch table entry for unreachable code. This saves space and permits a uniform treatment of branches.
  • Use the correct stack length for the Loop branch target (we're taking the branch before being in the label, so the current stack needs to be added).
  • Take the Else source and target branches at the correct time (i.e. when the stack is the expected one such that the stack length is correctly computed).

@ia0 ia0 requested review from zhouwfang and ia0-review March 7, 2025 10:07
The main changes are:
- Do not create a branch table entry for unreachable code. This saves space and permits a uniform
  treatment of branches.
- Use the correct stack length for the Loop branch target (we're taking the branch before being in
  the label, so the current stack needs to be added).
- Take the Else source and target branches at the correct time (i.e. when the stack is the expected
  one such that the stack length is correctly computed).
@ia0 ia0 merged commit 9f89c67 into google:dev/fast-interp Mar 7, 2025
19 checks passed
@ia0 ia0 deleted the pop-cnt branch March 7, 2025 10:22
@zhouwfang
Copy link
Contributor

#46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants