Skip to content

Add SideTableEntry #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 28, 2024
Merged

Add SideTableEntry #563

merged 13 commits into from
Aug 28, 2024

Conversation

zhouwfang
Copy link
Contributor

#46

@zhouwfang zhouwfang requested a review from ia0 as a code owner August 4, 2024 22:39
ia0
ia0 reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some comments that should hopefully simplify the logic. You could make the helper from/into functions into a bitfield module with unit-tests.

zhouwfang
zhouwfang commented Aug 7, 2024
View reviewed changes
@zhouwfang zhouwfang requested a review from ia0 August 7, 2024 04:01
ia0
ia0 reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I like the fact of using proptest for testing.

zhouwfang
zhouwfang commented Aug 8, 2024
View reviewed changes
@zhouwfang zhouwfang requested a review from ia0 August 8, 2024 02:47
ia0
ia0 reviewed Aug 8, 2024
View reviewed changes
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks good. Only the tests can be improved.

@zhouwfang zhouwfang requested a review from ia0 August 11, 2024 00:29
@zhouwfang zhouwfang requested review from ia0 and removed request for ia0 August 14, 2024 03:05
ia0
ia0 reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@ia0 ia0 force-pushed the dev/fast-interp branch from 8576088 to 597feb7 Compare August 28, 2024 11:32
@ia0 ia0 merged commit 382e573 into google:dev/fast-interp Aug 28, 2024
20 checks passed
@ia0 ia0 linked an issue Sep 19, 2024 that may be closed by this pull request
Interpreter performance and footprint #46
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia0 ia0 ia0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interpreter performance and footprint
2 participants
@zhouwfang @ia0