Fix neovim support #104
Merged
Fix neovim support #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 28, 2016 15:30
Use the newer API from the neovim python-client, this avoids having the the second unicde instance.
Previously Neovim did not wrap commands when calling the shell so shell.vroomfaker skipped the parsing step for Neovim. This is no longer the case restore the original behaviour.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
That CLA nag is weird. Different email address associated with the individual commits, perhaps? If that's the case, you can use |
|
No. I've checked, I'm using the exact same email address. Edit: Well the CLA form lists my google account email address, if that means anything. |
|
awesome! this should let me pick up #100 again |
agriffis
added a commit
to agriffis/vim-codefmt
that referenced
this pull request
Dec 30, 2019
Four problems that were preventing the vroom tests from running on neovim: - The vroom version was too old, see google/vroom#104 - The maktaba version was too old, see google/vim-maktaba#172. I considered constraining this to neovim but it applies to recent vim as well (the version of vim in travis/xenial is quite old) and the extra version checking seems pointless. - The get-pip.py invocation was outdated. - For some reason neovim pauses more often with "Hit ENTER" messages. Perhaps newer vim would too. In any case, increasing the cmdheight solves the problem without needing to sprinkle :silent everywhere.
agriffis
added a commit
to agriffis/vim-codefmt
that referenced
this pull request
Dec 30, 2019
Four problems that were preventing the vroom tests from running on neovim: - The vroom version was too old, see google/vroom#104 - The maktaba version was too old, see google/vim-maktaba#172. I considered constraining this to neovim but it applies to recent vim as well (the version of vim in travis/xenial is quite old) and the extra version checking seems pointless. - The get-pip.py invocation was outdated. - For some reason neovim pauses more often with "Hit ENTER" messages. Perhaps newer vim would too. In any case, increasing the cmdheight solves the problem without needing to sprinkle :silent everywhere.
dbarnett
pushed a commit
to google/vim-codefmt
that referenced
this pull request
Jan 1, 2020
Four problems that were preventing the vroom tests from running on neovim: - The vroom version was too old, see google/vroom#104 - The maktaba version was too old, see google/vim-maktaba#172. I considered constraining this to neovim but it applies to recent vim as well (the version of vim in travis/xenial is quite old) and the extra version checking seems pointless. - The get-pip.py invocation was outdated. - For some reason neovim pauses more often with "Hit ENTER" messages. Perhaps newer vim would too. In any case, increasing the cmdheight solves the problem without needing to sprinkle :silent everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One issue I've noticed is that examples/messages.vroom blocks waiting for input (set more seems to have no effect?) I'm stil investigating that one, but might be a legitimate difference in Neovim. Pretty annoying for Travis though, so I've disabled those tests for Neovim.