-
Notifications
You must be signed in to change notification settings - Fork 27
Description
While attempting to reproduce #13, I noticed that the message output I'm getting on failure is different to what was quoted. Instead of e.g.
FAILED on line 4: Expected message not received:
"Bar" (verbatim mode)
Message was "Foo"
Failed command on line 4:
[...]
I'm getting
FAILED on line 4: Expected message not received:
"Bar" (verbatim mode)
Messages:
Messages maintainer: Mike Williams <mrw@eandem.co.uk>
Foo
Failed command on line 4:
It turns out this is because I'm running with LANG=en_GB.UTF-8
, which changes at least the maintainer (which is hardcoded in vroom/messages.py
). Running as LANG=en_US vroom ...
DTRT.
Should vroom be setting LANG=en_US
(or LANG=C
?) before running vim? It's not entirely clear to me whether hardcoding this would be unnecessarily restrictive, or whether it affects anything else.
Alternatively, we could conceivably work out what the "Messages maintainer" message looked like ourselves, perhaps by running vim and dumping the messages with no input (or could we just do that as the first thing unconditionally?).