Skip to content

Conversation

cfc4n
Copy link
Member

@cfc4n cfc4n commented Aug 9, 2025

This pull request refactors the debug build workflow in .github/workflows/pr_build_debug.yml to simplify the build matrix, streamline artifact naming, and improve the clarity and maintainability of the process. The changes also separate the job responsible for commenting on the PR with download links.

Build matrix and artifact handling:

  • Simplified the build matrix by replacing the explicit list of artifact filenames with separate os and arch axes, making it easier to add or modify build targets in the future.
  • Updated artifact naming and upload logic to dynamically generate artifact names based on the current matrix values, improving consistency and reducing duplication.
  • Removed .deb package handling from the debug build process, focusing only on .tar.gz artifacts for each target.

Workflow structure improvements:

  • Added a separate comment-pr job that depends on the build job and is responsible for posting PR comments with download links, improving separation of concerns and workflow readability.

…uploads

Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
@cfc4n cfc4n requested a review from Copilot August 9, 2025 09:55
@cfc4n cfc4n added 🐞 bug Something isn't working fix bug fix PR labels Aug 9, 2025
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 9, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the GitHub Actions workflow for debug builds to improve maintainability and separation of concerns. The changes simplify the build matrix by replacing hardcoded artifact filenames with dynamic OS/architecture combinations and separate the PR commenting functionality into its own job.

Key changes:

  • Simplified build matrix from hardcoded artifact names to separate os and arch axes
  • Removed .deb package handling, focusing only on .tar.gz artifacts
  • Separated PR commenting into a dedicated job that depends on the build job

- name: Comment PR with Download Links
if: github.event_name == 'pull_request'
uses: actions/github-script@v7
with:
Copy link
Preview

Copilot AI Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub script action is missing the actual script content. The 'script:' property is declared but appears to be truncated in the diff, which would cause the workflow to fail.

Copilot uses AI. Check for mistakes.

@dosubot dosubot bot added the improve label Aug 9, 2025
Copy link

github-actions bot commented Aug 9, 2025

🔧 Debug Build Complete

📦 Download Links:

⏰ Files will be retained for 7 days, please download and test promptly.

Copy link

github-actions bot commented Aug 9, 2025

🔧 Debug Build Complete

📦 Download Links:

⏰ Files will be retained for 7 days, please download and test promptly.

@cfc4n cfc4n merged commit 8e504d0 into master Aug 9, 2025
10 checks passed
@cfc4n cfc4n deleted the bugfix/pr-build-matrix branch August 9, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working fix bug fix PR improve size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant