fix: Improve bash path detection and correct probe attachment #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses two issues in the bash probe logic: 1. **Unreliable Bash Path Discovery:** The probe previously relied solely on the `$SHELL` environment variable. This could fail on systems where `$SHELL` is not set to bash (e.g., using zsh or fish) or is not set at all. 2. **Incorrect Probe Attachment:** When bash was dynamically linked with `libreadline.so`, the probe incorrectly used the path to `libreadline.so` for all function hooks. This failed for functions like `execute_command`, `exec_builtin`, and `exit_builtin` which exist only in the main bash executable, not in the readline library. This patch introduces the following fixes: - Adds a fallback to check for `/bin/bash` if a valid bash path cannot be determined from the `$SHELL` variable. - Refactors the configuration and probe logic to distinguish between the path to the `bash` executable and the path to `libreadline.so`. - Ensures that probes for `readline` target either `libreadline.so` (if present) or the `bash` binary, while probes for other bash-internal functions always target the `bash` binary itself. This change significantly improves the reliability and accuracy of bash command capturing across different system configurations.
|
Two conditions was tested in my local environment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses two issues in the bash probe logic:
Unreliable Bash Path Discovery: The probe previously relied solely on the
$SHELLenvironment variable. This could fail on systems where$SHELLis not set to bash (e.g., using zsh or fish) or is not set at all.Incorrect Probe Attachment: When bash was dynamically linked with
libreadline.so, the probe incorrectly used the path tolibreadline.sofor all function hooks. This failed for functions likeexecute_command,exec_builtin, andexit_builtinwhich exist only in the main bash executable, not in the readline library.This patch introduces the following fixes:
/bin/bashif a valid bash path cannot be determined from the$SHELLvariable.bashexecutable and the path tolibreadline.so.readlinetarget eitherlibreadline.so(if present) or thebashbinary, while probes for other bash-internal functions always target thebashbinary itself.This change significantly improves the reliability and accuracy of bash command capturing across different system configurations.