Rearranged cache headers #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache headers are not set predictably. The cache headers are not being returned when deployed on an EC2. https://stackoverflow.com/questions/43202919/http-headers-not-returned-on-ec2
|
Thanks, but as far as i can see, we have this case covered in this unit test darkroom/internal/handler/image_test.go Line 66 in d9e74a9 or am i missing something here? |
|
This is unpredictable. It is working locally, but not on a prod environment (especially an Ubuntu-based EC2 instance). I am not too sure why exactly the order of setting headers matters except the fact that they become unpredictable after writing to the response body. |
|
An example of a cloud instance (No changes are done to darkroom - except S3 config here, everything else is default) Caching headers are not returned here |
|
Rearranged the headers in another instance & it works |
baskarap
approved these changes
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache headers are not set predictably. The cache headers are not being returned when deployed on an EC2.
https://stackoverflow.com/questions/43202919/http-headers-not-returned-on-ec2