Prometheus support #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajatprabha
reviewed
Sep 9, 2020
There was a problem hiding this comment.
Thank you for the contribution @Chaitanya2456!
The initial work looks good, I have added some comments.
One thing to keep in mind, Darkroom is now moving towards an optional cluster deployment approach, so we need to add a node label as well.
For example:
image_crop_duration_bucket{node="Darkroom@172.25.0.3",image_ext="png",le="0.005"} 0
Update: I noticed instance is already there.
I have not yet tested this locally, but it'd be great if you can also add a Grafana Dashboard spec later.
added 7 commits
September 13, 2020 21:34
…cal for testing and added gcc support for Docker
…ns in manipulator and errors in ImageHandler
…outes, so removed 'AddMetricsEndPoint()'
52a2b3b to
d69d6eb
Compare
added 4 commits
September 14, 2020 18:28
…due to duplicate registration, moved it to dependencies
…r_errors with additional labels
ajatprabha
reviewed
Sep 17, 2020
|
I tried running your PR locally, but for some reason the metrics are blank. Similarly, no data points in Grafana as well. |
ajatprabha
requested changes
Sep 18, 2020
ajatprabha
requested changes
Sep 23, 2020
ajatprabha
requested changes
Sep 24, 2020
ajatprabha
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The application itself now exposes metrics at "/metrics" endpoint. All types of duration metrics and storage, processor errors are tracked. For durations, histogram vectors are used and counters for storage/processor errors. The prometheus service is configured(using prometheus.yml that has scrape configs and targets) to scrape the metrics exposed by the application.
In the docker-compose.yml, prometheus service is included along with darkroom so that they can be deployed at once.