Add overlay support #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es into processor interface
kanisiuskenneth
approved these changes
Jan 16, 2020
ajatprabha
approved these changes
Jan 16, 2020
ajatprabha
pushed a commit
to ajatprabha/darkroom
that referenced
this pull request
Jul 19, 2020
* Introduce overlay that takes base image and array of overlay properties into processor interface * Add spec to apply overlay with one image right at the centre * Add spec to apply overlay with one image right at the top left * Refactor overlay test * Add specs to apply overlay with one image right at other sides * Add spec to overlay using multiple images * Reuse code from overlay in the existing watermark functionality * Rename OverlayProps -> OverlayAttrs * Add overlay function in mockProcessor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref for the issue: #48