Skip to content

markup/goldmark: Change link and image render hook enablement to enums #13816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

markup/goldmark: Change link and image render hook enablement to enums #13816

merged 1 commit into from
Jul 7, 2025

Conversation

jmooring
Copy link
Member

@jmooring jmooring commented Jun 22, 2025 •
edited
Loading

@jmooring jmooring force-pushed the change-link-and-image-render-hook-enablement-to-enum-13535 branch 4 times, most recently from cd0b9a0 to 2a2c7d0 Compare June 25, 2025 21:34
@jmooring jmooring marked this pull request as ready for review June 25, 2025 21:42
@jmooring jmooring force-pushed the change-link-and-image-render-hook-enablement-to-enum-13535 branch 2 times, most recently from 8596c61 to d200d3d Compare June 26, 2025 15:22
@jmooring jmooring requested a review from bep June 26, 2025 15:23
@jmooring jmooring mentioned this pull request Jun 29, 2025
Closed
@bep
Copy link
Member

bep commented Jul 5, 2025

I will have a closer look at this tomorrow. A side note, I'm planning on doing a v0.148.0 release on Monday with this and the other recent changes.

bep
bep reviewed Jul 6, 2025
View reviewed changes
@jmooring
Copy link
Member Author

jmooring commented Jul 6, 2025 •
edited
Loading

layouts/mysection/_markup/render-image.html

I did not consider higher-specificity user-defined templates when conceptualizing how this would work. To clarify, when renderHooks.link.useEmbedded is set to always, we must always use the embedded hook even if a higher-specificity user-defined template exists. I will fix this and add tests.

The auto, always, fallback, and never strings are used in enough places that I'm going to convert these to constants when used in a goldmark context.

@jmooring jmooring force-pushed the change-link-and-image-render-hook-enablement-to-enum-13535 branch from d200d3d to 08e03bd Compare July 6, 2025 23:16
@bep bep merged commit 84b3172 into gohugoio:master Jul 7, 2025
6 checks passed
@jmooring jmooring deleted the change-link-and-image-render-hook-enablement-to-enum-13535 branch July 7, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bep bep bep left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename config option for embedded renderhooks to useEmbedded ({never,always,fallback})
2 participants
@jmooring @bep