tpl/tplimpl: Copy embedded HTML table render hook to each output format #13813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1eb35f8 to
ec9075f
Compare
jmooring
added a commit
to jmooring/hugo-testing
that referenced
this pull request
Jun 23, 2025
See: - jmooring/hugo-module-backlinks#1 - gohugoio/hugo#13351 - gohugoio/hugo#13813 Requires Hugo v0.147.9 or later.
jmooring
added a commit
to jmooring/hugo-module-backlinks
that referenced
this pull request
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13351
With other render hooks we do something like this:
hugo/markup/goldmark/blockquotes/blockquotes.go
Lines 82 to 85 in b6c8dfa
where
renderBlockquoteDefaultis essentially copied from Goldmark's source. The bits that we're copying are short and simple. But the Goldmark source for tables (it's an extension) is neither short nor simple, so we panic instead:hugo/markup/goldmark/tables/tables.go
Lines 72 to 75 in b6c8dfa
Instead of trying to recreate Goldmark's table extension in a
renderTableDefaultfunction, this PR simply registers a copy of the embedded table render hook for all output formats.