commands: Make sure the browser gets refreshed on changes when --disableFastRender is set #13734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bleFastRender is set Fixes gohugoio#13727
5e1e893 to
f4b13f3
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the browser is force-refreshed on content changes even when --disableFastRender is enabled.
- Adds an
elsebranch to always calllivereload.ForceRefresh()when changes occur. - Duplicates the logging and refresh calls to cover both fast-render-enabled and disabled cases.
Comment on lines
972
to
+977
| lrl.Logf("force refresh") | ||
| livereload.ForceRefresh() | ||
| } | ||
| } else { | ||
| lrl.Logf("force refresh") | ||
| livereload.ForceRefresh() |
There was a problem hiding this comment.
The code for logging and forcing a refresh is duplicated in both branches. Consider moving lrl.Logf("force refresh") and livereload.ForceRefresh() after the if statement to reduce duplication and simplify the control flow.
Suggested change
| lrl.Logf("force refresh") | |
| livereload.ForceRefresh() | |
| } | |
| } else { | |
| lrl.Logf("force refresh") | |
| livereload.ForceRefresh() | |
| forceRefreshNeeded = true | |
| } | |
| } else { | |
| forceRefreshNeeded = true |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13727