Skip to content

Make isset warning message more actionable #8668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make isset warning message more actionable #8668

wants to merge 1 commit into from

Conversation

mhansen
Copy link

@mhansen mhansen commented Jun 19, 2021

  • Refer to the way that most users will call this: using the isset template
  • Log the key used as well -- this helps narrow down callers.

Before:

WARNING: calling IsSet with unsupported type "invalid" (<nil>) will always return false.

After:

WARNING: calling (isset %!q(<nil>) "taxonomycloud") with unsupported collection type "invalid" (<nil>) will always return false.

Addresses #8667

@mhansen
Make isset warning message more actionable
e6d968d 
- Refer to the way that most users will call this: using the `isset` template
- Log the key used as well -- this helps narrow down callers.

Before:

```
WARNING: calling IsSet with unsupported type "invalid" (<nil>) will always return false.
```

After:

```
WARNING: calling (isset %!q(<nil>) "taxonomycloud") with unsupported collection type "invalid" (<nil>) will always return false.
```
@mhansen mhansen mentioned this pull request Jun 19, 2021
Closed
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This PR has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help.
Please check https://github.com/gohugoio/hugo/blob/master/CONTRIBUTING.md#code-contribution and verify that this code contribution fits with the description. If yes, tell is in a comment.
This PR will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@github-actions github-actions bot added the Stale label Jan 6, 2022
@github-actions github-actions bot closed this Feb 18, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mhansen