exif: Allow more spacing characters in strings #8327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix the commit message? |
The root cause of issue gohugoio#8079 was a non-breaking space (U+0160). `unicode.IsPrint` only allows the ASCII space (U+0020). Be more lenient by using `unicode.IsGraphic` instead. Fixes gohugoio#8079
814c466 to
80b4923
Compare
|
Fixed. |
bep
requested changes
Mar 13, 2021
resources/images/exif/exif.go
Outdated
| @@ -227,7 +227,7 @@ func (e *exifWalker) Walk(f _exif.FieldName, tag *tiff.Tag) error { | |||
| func nullString(in []byte) string { | |||
| var rv bytes.Buffer | |||
| for _, b := range in { | |||
| if unicode.IsPrint(rune(b)) { | |||
| if unicode.IsGraphic(rune(b)) { | |||
There was a problem hiding this comment.
OK, taking a second look at this, there is one more error in this, as this will not handle multi-byte runes. See the loop in this example:
There was a problem hiding this comment.
Commit pushed. Fixing this should remove the need for the utf8.ValidString check. PTAL
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of issue #8079 was a non-breaking space (U+0160).
unicode.IsPrintonly allows the ASCII space (U+0020). Be more lenientby using
unicode.IsGraphicinstead.Fixes #8079