Skip to content

Rename taxonomy kinds from taxonomy to term, taxonomyTerm to taxonomy #7394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2020
Merged

Rename taxonomy kinds from taxonomy to term, taxonomyTerm to taxonomy #7394

merged 1 commit into from
Jun 18, 2020

Conversation

bep
Copy link
Member

@bep bep commented Jun 16, 2020 •
edited
Loading

And we have taken great measures to limit potential site breakage:

  • For disableKinds and outputs we try to map from old to new values if possible, if not we print an ERROR that can be toggled off if not relevant.
  • The layout lookup is mostly compatible with more options for the new term kind.

That leaves:

  • Where queries in site.Pages using taxonomy/taxonomyTerm Kind values as filter.
  • Other places where these kind value are used in the templates (classes etc.)

Fixes #6911
Fixes #7395

@bep bep mentioned this pull request Jun 16, 2020
Closed
@bep bep force-pushed the fix/taxo-vs-taxoterm branch 3 times, most recently from 57b8a3c to 0ac7f97 Compare June 17, 2020 17:06
@bep
Rename taxonomy kinds from taxonomy to term, taxonomyTerm to taxonomy
a7b303f 
And we have taken great measures to limit potential site breakage:

* For `disableKinds` and `outputs` we try to map from old to new values if possible, if not we print an ERROR that can be toggled off if not relevant.
* The layout lookup is mostly compatible with more options for the new `term` kind.

That leaves:

* Where queries in site.Pages using taxonomy/taxonomyTerm Kind values as filter.
* Other places where these kind value are used in the templates (classes etc.)

Fixes gohugoio#6911
Fixes gohugoio#7395
@bep bep force-pushed the fix/taxo-vs-taxoterm branch from 0ac7f97 to a7b303f Compare June 17, 2020 17:07
@bep
Copy link
Member Author

bep commented Jun 17, 2020

OK, I have revisited the "pages from data" which requires a fair amount of precision in this department -- and that went out with the bath water when it came to the taxonomies ...

I have taken great care to make this as bakwards compatible as possible (ref. the new ignoreErrors setting etc.) and I don't see any issues in any of the many sites that I somehow "manage". I will take the theme sites for a spin once this is in master... There will obviously be some odd site out there that will have an issue, but we really need to fix this.

Do I get a thumbs up? @digitalcraftsman @onedrawingperday @regisphilibert @kaushalmodi ...?

@bep bep changed the title Work in progress: Rename taxonomy kinds from taxonomy to term, taxonomyTerm to taxonomy Rename taxonomy kinds from taxonomy to term, taxonomyTerm to taxonomy Jun 17, 2020
@bep bep merged commit fc045e1 into gohugoio:master Jun 18, 2020
@jmooring
Copy link
Member

This is a welcome change. Thank you. Here are two examples of changes that we needed to make:

  1. CSS selectors based on kind in body classes.
  2. A custom meta description based on kind.

Both were trivial.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a way to "toggle off" errors Rename taxonomy kinds
2 participants
@bep @jmooring