Skip to content

Pagination: consider dropping href="#" for disabled buttons since it is an invalid fragment id #9149

@chalin

Description

@chalin

Great update in #8602 @jmooring!

Could we drop the invalid anchors (href="#") for disabled buttons?

<a href="#" aria-disabled="true" ...>

It's tripping link checking. For example, see

<a href="#" aria-disabled="true" aria-label="First" class="page-link" role="button" tabindex="-1"><span aria-hidden="true">&laquo;&laquo;</span></a>

Prior to #8602, the previous button omitted the href attribute when there was no previous page.

/cc @austinlparker @nate-double-u

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions