Skip to content

fix issue 2858 #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2017
Merged

fix issue 2858 #2872

merged 1 commit into from
Jul 26, 2017

Conversation

steven-zou
Copy link
Contributor

fix issue 2858

@steven-zou steven-zou requested a review from wy65701436 July 26, 2017 07:53
wy65701436
wy65701436 approved these changes Jul 26, 2017
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-zou steven-zou merged commit 5c32719 into goharbor:master Jul 26, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 54.093% when pulling 7244134 on steven-zou:master into 7a0fe10 on vmware:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steven-zou @coveralls @wy65701436 @vmwclabot