Skip to content

feat: build arm64 image #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 8, 2024
Merged

feat: build arm64 image #244

merged 3 commits into from
Jan 8, 2024

Conversation

Desiki-high
Copy link
Collaborator

@Desiki-high Desiki-high commented Jan 4, 2024 •
edited
Loading

Since we have arm64 release binaries, we can also build arm64 images.

Ref: https://docs.docker.com/build/ci/github-actions/multi-platform.

  1. set up latest version.
  2. change the image tag from v0.x.x to 0.x.x.
  3. upload repo description.
  4. support the linux/arm64 image.

Test in my repo:
release action: https://github.com/Desiki-high/acceleration-service/actions/runs/7443126413
docker hub image: https://hub.docker.com/r/dingyadong/harbor-acceld and tag 0.2.8.

@Desiki-high
deps: update deps version
c8424be 
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@Desiki-high Desiki-high changed the title [WIP] feat: build arm64 image feat: build arm64 image Jan 4, 2024
@Desiki-high Desiki-high changed the title feat: build arm64 image [WIP]feat: build arm64 image Jan 4, 2024
@Desiki-high Desiki-high changed the title [WIP]feat: build arm64 image feat: build arm64 image Jan 4, 2024
@Desiki-high Desiki-high requested a review from imeoer January 4, 2024 06:31
@Desiki-high
Copy link
Collaborator Author

@imeoer Can we release a new version to test the arm64 image after merging?

@Desiki-high
doc: add dockerhub link and description
85e2418 
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@Desiki-high Desiki-high force-pushed the bump-action-build branch 5 times, most recently from 6bc6682 to 1f50e48 Compare January 7, 2024 08:28
imeoer
imeoer reviewed Jan 8, 2024
View reviewed changes
imeoer
imeoer reviewed Jan 8, 2024
View reviewed changes
imeoer
imeoer reviewed Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

@Desiki-high Desiki-high force-pushed the bump-action-build branch 2 times, most recently from c374c0e to 42c0521 Compare January 8, 2024 03:20
@Desiki-high Desiki-high requested a review from imeoer January 8, 2024 03:20
@Desiki-high Desiki-high force-pushed the bump-action-build branch 2 times, most recently from 6954e77 to cd33d02 Compare January 8, 2024 03:58
@Desiki-high
feat: docker image support arm64
450e4d0 
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
imeoer
imeoer approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@imeoer imeoer merged commit b82ccee into goharbor:main Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeoer imeoer imeoer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Desiki-high @imeoer