fix: use same cache repo for different tagged repo #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

imeoer merged 1 commit into goharbor:main from PerseidMeteor:feat-use-one-cache-repo

Sep 5, 2023

Collaborator

PerseidMeteor commented Aug 31, 2023

Now same repoes with different tag converts with same cache repo, but the cache tag is different. This will result in very few or even no use of the cache layer in the converted cache, so we have make the same repo using the same tagged cache repo.

change

make cache repo with same tag

imeoer reviewed

View reviewed changes

misc/config/config.nydus.ref.yaml Outdated Show resolved Hide resolved

imeoer reviewed

View reviewed changes

misc/config/config.nydus.yaml Outdated Show resolved Hide resolved

pkg/adapter/rule.go Outdated Show resolved Hide resolved

pkg/adapter/rule.go Outdated Show resolved Hide resolved

pkg/adapter/rule.go Outdated Show resolved Hide resolved

PerseidMeteor force-pushed the feat-use-one-cache-repo branch from 97201f7 to 785c74d Compare

September 1, 2023 03:08

imeoer reviewed

View reviewed changes

misc/config/config.nydus.ref.yaml Outdated Show resolved Hide resolved

imeoer reviewed

View reviewed changes

misc/config/config.nydus.yaml Outdated Show resolved Hide resolved

imeoer reviewed

View reviewed changes

pkg/adapter/rule.go Outdated Show resolved Hide resolved

imeoer reviewed

View reviewed changes

pkg/adapter/rule.go Outdated Show resolved Hide resolved

imeoer reviewed

View reviewed changes

pkg/adapter/rule.go Outdated Show resolved Hide resolved

imeoer reviewed

View reviewed changes

pkg/adapter/rule.go Outdated Show resolved Hide resolved

PerseidMeteor force-pushed the feat-use-one-cache-repo branch 2 times, most recently from 3361bb4 to c147c7f Compare

September 1, 2023 07:17

imeoer reviewed

View reviewed changes

pkg/errdefs/errors.go Outdated Show resolved Hide resolved

pkg/errdefs/errors.go Outdated Show resolved Hide resolved


          fix: use same cache repo for different tagged repo

4a854ed

Now  same repoes with different tag converts with same cache repo, but the cache tag is different. This will result in very few or even no use of the cache layer in the converted cache, so we have make the same repo using the same tagged cache repo.

Signed-off-by: YuQiang <y_q_email@163.com>

PerseidMeteor force-pushed the feat-use-one-cache-repo branch from c147c7f to 4a854ed Compare

September 4, 2023 12:05

imeoer approved these changes

View reviewed changes

Collaborator

imeoer left a comment

Thanks, LGTM!

imeoer merged commit f1e1593 into goharbor:main

PerseidMeteor deleted the feat-use-one-cache-repo branch

September 5, 2023 02:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet