Skip to content

gc: add scheduled gc task #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2023
Merged

gc: add scheduled gc task #179

merged 1 commit into from
Sep 6, 2023

Conversation

Desiki-high
Copy link
Collaborator

  • Add scheduled GC task, we will start GC every hour.
  • It will start the schedule after creating LocalAdapter.
  • The scheduled GC task will reduce local storage to less than 40 percent of the threshold.
    Ref: Feature request: manage local layer caches #141

@Desiki-high Desiki-high mentioned this pull request Aug 30, 2023
Closed
imeoer
imeoer reviewed Sep 1, 2023
View reviewed changes
@Desiki-high Desiki-high requested a review from imeoer September 2, 2023 06:12
@Desiki-high Desiki-high force-pushed the gc-task branch 2 times, most recently from c72a561 to 57d7012 Compare September 4, 2023 01:31
imeoer
imeoer reviewed Sep 5, 2023
View reviewed changes
@Desiki-high Desiki-high force-pushed the gc-task branch 3 times, most recently from adcd0ea to a8df97d Compare September 5, 2023 04:54
@Desiki-high Desiki-high requested a review from imeoer September 5, 2023 04:57
imeoer
imeoer reviewed Sep 6, 2023
View reviewed changes
@Desiki-high
gc: add scheduled gc task
65f8c55 
- Add scheduled GC task, we will start GC every hour.
- It will start the schedule after creating LocalAdapter.
- The scheduled GC task will reduce local storage to less than 40 percent of the threshold.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
imeoer
imeoer approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imeoer imeoer merged commit a7aa579 into goharbor:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeoer imeoer imeoer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Desiki-high @imeoer