feat: add localWriter #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25e90db to
286927a
Compare
imeoer
reviewed
Aug 7, 2023
We add localWriter to wrap content.Writer in the content store to make sure not to write any labels in boltdb by rewrite ```Commit``` method. In that case, we can make gc work well with the lease. Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
286927a to
9a17d23
Compare
imeoer
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure not to write any labels in the content bucket.
Labels in db will cause the blobs of the same image to be related to each other and can only be cleaned at the same time.
content.Store.Update.content.Writer.Commit.We add LocalWriter to wrap writer in the content store to make sure not to write any labels in boltdb. In that case, we can make gc work well with the lease.
Changes：
LocalWriter.content.Writer.Commitmethod.Ref: #141