feat: resolve error in highly concurrent by singleflight #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4e401f to
a1b7500
Compare
a1b7500 to
80b3c63
Compare
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
80b3c63 to
dd7315e
Compare
Fixes: goharbor#46 Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
|
@imeoer All fixed. PTAL. |
imeoer
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
acceldhandles highly concurrent conversion tasks, the content store will be locked because of fetching the same layer.Changes:
LocalAdapter.Dispatch. If the image ref is the same, we only convert once simultaneously.fetchHandler. If thedesc.Digestis the same, we only fetch once simultaneously.Github Action:
In Integration Test, we can move accel check out of build, it will make ci faster.
resolve #46.