Skip to content

feat: use runtime errors instead of compilation errors for unusupported platforms #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2024
Merged

feat: use runtime errors instead of compilation errors for unusupported platforms #85

merged 1 commit into from
Jul 2, 2024

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jul 2, 2024 •
edited
Loading

Instead of being blocked on unsupported platforms (*/wasm and plan9/*), flock will throught runtime errors.

The errors are:

	return &fs.PathError{
		Op:   "RLock",
		Path: f.Path(),
		Err:  errors.ErrUnsupported,
	}

The implementation for unsupported platforms can be added in the future.

Fixes #60

@ldez ldez changed the title feat: use runtime errors instead of compilation errors for unusupported platform feat: use runtime errors instead of compilation errors for unusupported platforms Jul 2, 2024
@ldez ldez merged commit c527283 into gofrs:master Jul 2, 2024
@ldez ldez deleted the feat/runtime-errors branch July 2, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement os/js os/plan9 os/wasip1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot build on */wasm, plan9/*
1 participant
@ldez