Add directory support #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theckman
reviewed
Aug 22, 2020
flock.go
Outdated
| return err | ||
| // retry for directory | ||
| errno := err.(*os.PathError).Err.(syscall.Errno) | ||
| if errno == syscall.EISDIR { |
There was a problem hiding this comment.
I'm a little worried that if we add another platform, like the in-development AIX code, this will break. Is this constant available on all platforms that Go supports out of the box?
theckman
requested changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to flock a directory by retrying without
os.O_CREATEif the syscall returnssyscall.EISDIR.There is now two instance of the same test suite, one creating a temporary file, the other, a temporary directory.
btw,
reopenFDOnErroralso useos.OpenFile, but I was unable to trigger this path via the tests. From Linux, I don't think that the hack is needed anymore (hopefully, otherwise,flockcan't be use on directory via NFS as unable to open it withos.O_RDWR).btw, Windows is not supported, I was unable to find a locking function for directories (and also, unable to test it).