Skip to content

pr for readme #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2020
Merged

pr for readme #20

merged 2 commits into from
Feb 17, 2020

Conversation

novalagung
Copy link
Contributor

  • use markdown code block with specified language
  • use space instead tabs
  • and fix some typo
  • sentence adjustment

@novalagung novalagung requested a review from tgulacsi February 17, 2020 05:06
@tgulacsi tgulacsi merged commit aabdddc into godror:master Feb 17, 2020
@tgulacsi
Copy link
Contributor

Thanks!

If you have time, I'd love a better, more concise separation of the README and the godoc: the README shold contain only directions and warnings, general higher level picture, while godoc should contain the nitty-gritty details...

@novalagung
Copy link
Contributor Author

@tgulacsi sure, I would love to do that. let's see what I can do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgulacsi tgulacsi Awaiting requested review from tgulacsi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@novalagung @tgulacsi