Golang x text encoding #772
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for _, f := range diff.Files { | ||
| for _, sec := range f.Sections { | ||
| for _, l := range sec.Lines { | ||
| l.Content = decoder.ConvertString(l.Content) | ||
| if c, _, err := transform.String(d, l.Content); err == nil { |
There was a problem hiding this comment.
I use here 'c' and 'd' in order not to go over 80 chars.
|
I've made a branch encoding, please re-PR to this so we can make some tests then decide should we approach this way or not. thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits remove the mahonia module and replaces it with the standard functions of the Golang Sub-repositories http://godoc.org/golang.org/x/text/transform and http://godoc.org/golang.org/x/net/html/charset (which are using http://godoc.org/golang.org/x/text/encoding)
This is just one suggestion, I am happy to implement things differently if we want to keep the mahonia module in some form.