Skip to content

Git LFS support #3868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

Git LFS support #3868

wants to merge 16 commits into from

Conversation

fabian-z
Copy link

@fabian-z fabian-z commented Nov 8, 2016 •
edited
Loading

Requested in #1322

This PR implements Git LFS support for Gogs, supporting the legacy v1 API as well as the current batch v1 API.

Originally imported LFS server code base from https://github.com/git-lfs/lfs-test-server.

Features:

  • Uses recommended paths with HTTP and SSH remotes, no custom user settings necessary
  • Supports basic authentication with user credentials
  • Supports authentication with SSH (passing JWT under the hood)
  • Supports no authentication when pulling public repositories (however git-lfs still asks for credentials, where the prompt can be skipped - likely a bug in git-lfs)
  • Settings transparently integrated into installation process
  • Removes LFS objects when repositories are deleted. Works with forks (e.g. when parent repository is deleted)

Notes:

Looking forward to your review!

fabian-z and others added 14 commits November 6, 2016 18:45
@fabian-z
Update dependency versions
58375e6 
Fixes xorm error: "cannot use x (type *xorm.Engine) as type Engine in
argument to"
@fabian-z
Import github.com/git-lfs/lfs-test-server as lfs module base
aca09ac 
Imported commit is 3968aac269a77b73924649b9412ae03f7ccd3198

Removed:

Dockerfile CONTRIBUTING.md mgmt* script/ vendor/ kvlogger.go
.dockerignore .gitignore README.md
@fabian-z
Remove config, add JWT support from github.com/mgit-at/lfs-test-server
ff281f9 
Imported commit f0cdcc5a01599c5a955dc1bbf683bb4acecdba83
@fabian-z
Add LFS settings
5265ad1
@fabian-z
Add LFS meta object model
7423b5b
@fabian-z
Add LFS routes and initialization
46d770f
@fabian-z
Adapt LFS module: handlers, routing, meta store
52d7fff
Move LFS routes to /user/repo/info/lfs/*
0f95196
Add request header checks to LFS BatchHandler / PostHandler
8c8fdeb
Implement LFS basic authentication
3c11ce9
Rework JWT secret generation / load
11d00a8
@fabian-z
Implement LFS SSH token authentication with JWT
11f946c 
Specification: https://github.com/github/git-lfs/tree/master/docs/api
@fabian-z
Integrate LFS settings into install process
c166480
@fabian-z
Regenerate bindata
0344f98
@fabian-z fabian-z mentioned this pull request Nov 8, 2016
Closed
@lunny
Copy link
Contributor

lunny commented Nov 8, 2016

@fabian-z hi, could you please send it to github.com/go-gitea/gitea master.

@fabian-z
Copy link
Author

fabian-z commented Nov 8, 2016 •
edited
Loading

For the record:
Travis CI fails during go get for Go 1.4 because of missing base64.RawURLEncoding, which is used to store the generated JWT secret in the configuration.
The *.ini parser doesn't play nice with padded base64 encodings and the unpadded encodings were introduced with Go 1.5.
Could a contributor clarify on whether Go 1.4 must still be supported?

@lunny: PR as requested

@fabian-z fabian-z mentioned this pull request Nov 8, 2016
Closed
Fabian added 2 commits November 8, 2016 16:06
Remove LFS objects when repository is deleted
d8b080b 
Only removes objects from content store when deleted repo is the only
referencing repository
Make LFS module stateless
d7ea619 
Fixes bug where LFS would not work after installation without
restarting Gogs
@fabian-z fabian-z mentioned this pull request Nov 8, 2016
Merged
@fabian-z
Copy link
Author

This PR received significant review and further development in go-gitea/gitea#122. If there is any interest in merging this, the commits made to that PR branch would need to be rebased for gogs.

@unknwon unknwon added the status: review later The pull request is not confident to be review at the moment label Dec 22, 2016
@fabian-z
Copy link
Author

Since this feature now got merged with Gitea, I'll be keeping around my repository with the changes in this PR as https://github.com/fabian-z/gogs-legacy for some time. It contains the develop branch with my original changeset for Gogs and the gitea_lfs branch with the polished changeset rebased for Gitea.

If this feature should be brought to Gogs, it will need someone to rebase my original branch and apply the rest of the changeset from my gitea_lfs branch, adapting the changes.

@fabian-z fabian-z closed this Dec 26, 2016
Martchus pushed a commit to Martchus/gogs that referenced this pull request Jun 7, 2018
@lafriks
Fix docs site index page (gogs#3868) (gogs#3881)
d0a9957
Martchus pushed a commit to Martchus/gogs that referenced this pull request Aug 27, 2018
@thehowl @lafriks
Fix docs site index page (gogs#3868)
3e578b5
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
status: review later The pull request is not confident to be review at the moment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabian-z @lunny @unknwon