-
Notifications
You must be signed in to change notification settings - Fork 5k
GitHub-API compliance #3742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
GitHub-API compliance #3742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have conflicts here, are you willing to fix? |
@unknwon Done, and I renamed the function to align with the conflicing change :) |
Thanks! Any idea why CI both are failing? |
1d0f3dc
to
3413593
Compare
Thanks for the update, but code isn't seem compiling... |
Merged
Closed by #4549. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
status: needs feedback
Tell me more about it
status: waits for review
It is waiting to be reviewed by maintainers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues with the Gogs API.
Also adds the undocumented endpoint
/repositories/:id
(which is used by Octokit)Closes #3729