• Gogs version (or commit ref): 0.9.99.0903
• Git version: 2.1.4
• Operating system: Debian Jessie
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • SQLite
• Can you reproduce the bug at https://try.gogs.io:
  • Yes (provide example URL)
  • No
  • Not relevant

Description

Hi,

I've recently noticed that our latest builds in Drone is missing author information. After some investigation I discovered that the webhook payloads sent from Gogs changed after upgrading from Gogs v0.9.71 (I believe).

Drone is expecting to find the author information in sender->login, but the login attribute have been renamed to username. See github.com/drone/drone/gogs/helper.go and github.com/drone/drone/gogs/types.go.

Was this change intentional? I am unsure of the goal of Gogs webhook format, but github's format is sender->login, not sender->username. See https://developer.github.com/webhooks/.

If this change was intentional I can open a new Drone issue so they can fix this incompatibility.