Skip to content

fix(net/goai): embedded struct with tags also expand as properties of the parent struct #3956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2024
Merged

fix(net/goai): embedded struct with tags also expand as properties of the parent struct #3956

merged 2 commits into from
Nov 23, 2024

Conversation

wlynxg
Copy link
Contributor

@wlynxg wlynxg commented Nov 21, 2024

fix: #3930

@gqcn gqcn changed the title fix: embedded struct with tags also expand as properties of the parent struct fix(net/goai): embedded struct with tags also expand as properties of the parent struct Nov 21, 2024
@gqcn
Copy link
Member

gqcn commented Nov 21, 2024

@wlynxg Please submit associated unit testing case for this update.

@gqcn gqcn added the ready to merge Used in PR, which means this PR is reviewed. label Nov 22, 2024
@gqcn gqcn merged commit ee3eb8d into gogf:master Nov 23, 2024
20 checks passed
@wlynxg wlynxg deleted the issue3930 branch November 26, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gqcn gqcn gqcn approved these changes

Assignees
No one assigned
Labels
ready to merge Used in PR, which means this PR is reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

net/goai: embedded struct attributes in response struct do not show in OpenAPIv3 document
2 participants
@wlynxg @gqcn