Add error for unterminated flow mapping node #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
=======================================
Coverage 76.71% 76.71%
=======================================
Files 12 12
Lines 2946 2946
=======================================
Hits 2260 2260
Misses 461 461
Partials 225 225 |
|
Sorry for the late reply. LGTM :) I'll merge it . |
|
I also currently working on fixing a unterminated string issue . Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @goccy, I found your yaml parser as an alternative to go-yaml, and it seems to handle several cases that go-yaml/yaml doesn't: not just anchors and aliases, but also repeated flow documents (
{ ... }{ ... }) and tabs in flow documents, which I think would allow us to replace our use ofencoding/jsonwith it.I created this pull request to add one piece of error handling, for unterminated flow documents—please let me know what you think, or if there's more I can or should do to improve it. Also please let me know if other pull requests would be welcome. There are two other changes I'd be interested in making, if you're open to them:
"abc...<EOF>)I'd be happy to get in touch if you want to discuss these further.
Thanks for creating such a great library!