Prevent panic when decoding string named types #743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #743 +/- ##
==========================================
+ Coverage 77.83% 77.85% +0.02%
==========================================
Files 22 22
Lines 8056 8064 +8
==========================================
+ Hits 6270 6278 +8
Misses 1370 1370
Partials 416 416 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Adds support for decoding YAML values into string-alias types without panicking, along with corresponding tests.
- Introduce
TestStringalias and new test cases for mapping both unquoted and numeric YAML values intoTestString. - Refactor
convertValueto collect primitive values into astrValbefore converting to the target type, then special-case named string types.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| decode_test.go | Adds TestString alias and table-driven tests for mapping YAML values into TestString. |
| decode.go | Refactors convertValue to accumulate a string buffer, then convert to alias string types. |
Comments suppressed due to low confidence (2)
decode.go:637
- This condition will return early for non-string kinds (e.g. int) when targeting a string alias, causing a panic instead of going through the intended numeric-to-string conversion path. Consider changing to
v.Type().Kind() == reflect.Stringor removing this early return so that numeric and boolean kinds hit the switch and get formatted into strings first.
if typ.Kind() == reflect.String && v.Type().Kind() != reflect.String {
decode_test.go:40
- Tests cover string and numeric inputs for
TestString, but boolean and float values for the alias are not verified. Adding cases likesource: "v: true\n", value: map[string]TestString{"v": "true"}and a float test will ensure full coverage of all primitive-to-string conversions.
{
goccy
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #741
Previously, decoding string named type fields returned the converted string values directly, which could lead to a panic if the types didn’t match. This update adds a type check and performs the conversion if the types do not match.
Before submitting your PR, please confirm the following.