feat: Dont make copies of structs for validation #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #737 +/- ##
=======================================
Coverage 77.94% 77.94%
=======================================
Files 22 22
Lines 7998 7998
=======================================
Hits 6234 6234
Misses 1349 1349
Partials 415 415 🚀 New features to boost your workflow:
|
b6dea53 to
69ce48c
Compare
shuheiktgw
commented
May 17, 2025
| @@ -1442,7 +1442,7 @@ func (d *Decoder) decodeStruct(ctx context.Context, dst reflect.Value, src ast.N | |||
| } | |||
|
|
|||
| if d.validator != nil { | |||
| if err := d.validator.Struct(dst.Interface()); err != nil { | |||
| if err := d.validator.Struct(dst.Addr().Interface()); err != nil { | |||
There was a problem hiding this comment.
dst is guaranteed to be addressable. See this line.
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the struct validation process by passing a pointer to the validator instead of a value, preventing unnecessary copying of structs.
- Changed the validator call from using dst.Interface() to dst.Addr().Interface()
- Improves efficiency by avoiding struct copies in validation
Comments suppressed due to low confidence (1)
decode.go:1445
- Consider verifying that 'dst' is addressable before calling .Addr(), to ensure that this change does not lead to runtime panics when 'dst' is not addressable.
if err := d.validator.Struct(dst.Addr().Interface()); err != nil {
|
Thanks! You can close my original PR #665 |
|
LGTM 👍 |
shuheiktgw
added a commit
that referenced
this pull request
Jun 20, 2025
This reverts commit 04f9bb5.
goccy
pushed a commit
that referenced
this pull request
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this comment, I took over the original PR and updated it.
Before submitting your PR, please confirm the following.