Skip to content

chore: clarify omitempty behaviour. #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Conversation

bwplotka
Copy link
Contributor

Fixes 0 step from #695.

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.89%. Comparing base (ee37df7) to head (f06d60a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #696   +/-   ##
=======================================
  Coverage   77.89%   77.89%           
=======================================
  Files          22       22           
  Lines        7965     7965           
=======================================
  Hits         6204     6204           
  Misses       1348     1348           
  Partials      413      413           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Fixes 0-1 steps from goccy#695.

Signed-off-by: bwplotka <bwplotka@gmail.com>
@bwplotka bwplotka force-pushed the omitempty-clarify branch from 8fafbd4 to f06d60a Compare April 15, 2025 07:12
@bwplotka
Copy link
Contributor Author

cc @goccy

Copy link
Owner

@goccy goccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thank you for your great PR ! 😄

@goccy goccy merged commit d1e3460 into goccy:master Apr 16, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants