Skip to content

fix: support for embedding alias of primitive types #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2022
Merged

fix: support for embedding alias of primitive types #378

merged 1 commit into from
Jul 5, 2022

Conversation

orisano
Copy link
Contributor

@orisano orisano commented Jul 4, 2022

fix #372

@codecov-commenter
Copy link

Codecov Report

Merging #378 (f0e6a54) into master (1468eef) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
+ Coverage   79.93%   79.94%   +0.01%     
==========================================
  Files          52       52              
  Lines       17565    17575      +10     
==========================================
+ Hits        14040    14050      +10     
  Misses       2957     2957              
  Partials      568      568

goccy
goccy approved these changes Jul 5, 2022
View reviewed changes
Copy link
Owner

@goccy goccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@goccy goccy merged commit 554506d into goccy:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goccy goccy goccy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unmarshaling omits embedded pointer to an aliased primitive
3 participants
@orisano @codecov-commenter @goccy