fix stream tokenizing respecting UseNumber #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
=======================================
Coverage 79.95% 79.95%
=======================================
Files 52 52
Lines 17555 17558 +3
=======================================
+ Hits 14036 14039 +3
Misses 2951 2951
Partials 568 568 |
|
Thank you for the contribution !! LGTM ! |
|
Thanks for merging this @goccy when can i expect a version cut with this so I can point at it instead of my branch? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using a decoder stream to read a Token at a time, it does not respect the
UseNumbersetting and unconditionally returns afloat64instead. This fixes the stream handling to properly respect theUseNumbersetting. Also adds a unit test for the case.