Fix mapassign_faststr for indirect struct type #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
+ Coverage 81.33% 85.95% +4.61%
==========================================
Files 47 47
Lines 15530 17034 +1504
==========================================
+ Hits 12632 14642 +2010
+ Misses 2338 1931 -407
+ Partials 560 461 -99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #282
Similar correspondence
https://github.com/qyl2021/go-ugorji-go is corresponded similar problem .
This project says indirect element is decided by element size ( whether more than 128 bytes or not ), and only support map_fastxxx APIs at not indirect element case ( element size is 128 bytes or less )
maxKeySizeandmaxElemSizeare also defined in the latest source code.https://github.com/golang/go/blob/7622e41c84fd9bb003a2d905b9f0545344842c3a/src/runtime/map.go#L74-L79